Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-20440 Update sample footprints notebook in display_firefly #31

Merged
merged 3 commits into from Jul 3, 2019
Merged

DM-20440 Update sample footprints notebook in display_firefly #31

merged 3 commits into from Jul 3, 2019

Conversation

stargaser
Copy link
Contributor

Update HSC-Footprints demo notebook:

  • Update the path to point to data that currently exist
  • Delete the custom channel, since the Firefly extension handles channel automatically

@stargaser stargaser requested a review from gpdf July 3, 2019 20:14
gpdf
gpdf reviewed Jul 3, 2019
View reviewed changes
Copy link
Contributor

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, David, looks good. I ran it successfully! One thing: can you add to the documentation a recommendation that a "medium" or larger LSP Notebook instance be used? We got some feedback from Simon, I recall, that this was good advice for the test case.

gpdf
gpdf approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc update. Ready for launch!

@stargaser stargaser merged commit d26c951 into master Jul 3, 2019
@stargaser stargaser deleted the tickets/DM-20440 branch July 3, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpdf gpdf gpdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stargaser @gpdf