Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-28658: remove displayLib #37

Merged
merged 1 commit into from Mar 22, 2021
Merged

DM-28658: remove displayLib #37

merged 1 commit into from Mar 22, 2021

Conversation

mwittgen
Copy link
Contributor

No description provided.

@mwittgen mwittgen changed the title remove displayLib DM-28658: remove displayLib Feb 23, 2021
@gpdf
Copy link
Contributor

gpdf commented Mar 11, 2021

Sorry for the lack of attention to this PR. We weren't aware that there was any activity likely on this repo and haven't been watching it closely. As I mentioned just now on the associated JIRA ticket, we are working on a migration of display_firefly to the new conda-based build scheme, eliminating the eups dependency on firefly_client. If that works in the next couple of days, then we'll turn to your PR (which certainly looks reasonable).

@gpdf gpdf requested review from robyww and gpdf March 11, 2021 19:40
@mwittgen
Copy link
Contributor Author

I can rebase as well after your changes are done.

Copy link

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@mwittgen mwittgen merged commit c675373 into master Mar 22, 2021
@mwittgen mwittgen deleted the tickets/DM-28658 branch March 22, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants