DM-10552: Upgrade display_firefly to work with more servers #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stargaser
commented
May 22, 2017
•
stargaser
commented
- Add basedir parameter and pass kwargs to constructor
- Improve uploading of images and masks
- Update _erase to leave masks displayed
stargaser
force-pushed
the
tickets/DM-10552
branch
from
7e5ad37
to
fd9c6c4
Compare
stargaser
force-pushed
the
tickets/DM-10552
branch
from
fd9c6c4
to
32bc451
Compare
- use FireflyClient.upload_data stream method,
to avoid Python 3 warnings about not closing files
- restore the mask labels that were removed on the Firefly
server side
stargaser
force-pushed
the
tickets/DM-10552
branch
from
32bc451
to
6018456
Compare
|
Review comments and responses in the corresponding JIRA ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.