New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-35962: Remove examples/ from all packages #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This being a notebook makes me wonder if the content of the notebook covers items that are missing from the documentation.
The notebook here doesn't have any narrative structure, so it's not clear what it's supposed to be demonstrating. This package is missing from the pipeline docs, and doesn't have a correctly-configured |
Ok. The lack of tests in the display packages has always been a problem (it seems there should be a set of tests in afw that the display packages could reuse). |
We also clearly have issues in the ability of users to treat afw.display as clearly a backend-agnostic base. I have recently seen examples where people have completely different call sequences to afw.display depending on which back end they are using. I think we need a sprint on improving the situation, which could include releasing some more solid tutorial code in a CI-able place. I've been discussing this with @frossie . |
(no objections to removing this particular notebook, for now) |
We also clearly have issues in the ability of users to treat afw.display as clearly a backend-agnostic base. I have recently seen examples where people have completely different call sequences to afw.display depending on which back end they are using.
Can you provide some examples? Esp. with display_astrotools becoming available, I agree that now'd be a good time to take a look.
R
|
display_astrowidgets, I think you mean? |
I'm mostly thinking of things I've seen in people's personal code, and I'm not trying to embarrass anyone. It looked to me like the issue was that laying out a multi-image display grid can't be done in a backend-independent way. I haven't had the time to dig into it - I don't know if it's a weakness in the common API, or a (fixable) difference in how the backends respond to it, or what. It's also the case that displaying a catalog over an image from afw.display is being done in a way that makes it impossible to take advantage of a lot of the power of Firefly for working with overlays. We need to come back to that point - we stalled out on that, collectively, when it first came up. We haven't seriously looked at this whole system since ~2018, so I think it's time for a sprint on this. |
Finally getting back to this: the discussion above was useful, but there were no objections to removing this notebook, so I am going to merge this ticket. |
No description provided.