DM-43682: external contributions from matplotlib dev #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pyplot.rc_context is a wrapper of matplotlib.rc_context - pyplot.cm is a re-export of matplotlib.cm - set the current axes of the Figure in question without affecting global current figure
Sniffing for `obj.number` is actually checking for "pyplot managed figures" not any figure (the attribute gets monkey-patched in as part of creating and registering the FigureManger via `plt.figure`). As matplotlib is already unconditionally imported in this module do the isinstance check directly. The try...except is to support matplotlib < 3.4 when we added support for SubFigure.
This enables the user to do: sys.modules['matplotlib.pyplot'] = None to make ensure that they can avoid the global state associated with pyplot if they wish.
TallJimbo
force-pushed
the
tickets/DM-43682
branch
from
0967e12
to
6ea159e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.