Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42862: Initial ComCamSim Pipeline #105

Merged
merged 6 commits into from Feb 15, 2024
Merged

DM-42862: Initial ComCamSim Pipeline #105

merged 6 commits into from Feb 15, 2024

Conversation

yalsayyad
Copy link
Contributor

No description provided.

yalsayyad and others added 4 commits February 12, 2024 15:47
- Remove GBDES
- Clarify inline comments
to true for all DRP pipelines. That will create an intermediate
data product to help validate coverage of templates
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on the TODOs.

And I didn't know you could make a parameters: section. Very handy!

class: lsst.drp.tasks.update_visit_summary.UpdateVisitSummaryTask
config:
# TODO: Evaluate GBDES and skyCorr after initial DRP
wcs_provider: "input_summary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to note the TODO here for fgcmcal after first round, and in the following line after skycorr evaluation.

@yalsayyad yalsayyad merged commit a75787d into main Feb 15, 2024
3 checks passed
@yalsayyad yalsayyad deleted the tickets/DM-42862 branch February 15, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants