DM-43049: Add more plots to LsstComCamSim #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to skip these plots since they work in CI. Also added validateObjectTableCore to DRP-ops-rehearsal-3.yaml.
taranu
force-pushed
the
tickets/DM-43049
branch
from
b01dbf9
to
0d42b52
Compare
yalsayyad
approved these changes
Feb 28, 2024
| - validateObjectTableCore | ||
| - analyzeMatchedVisitCore | ||
|
|
There was a problem hiding this comment.
We don't usually incl whitespace between task lists and descriptions
| python: | | ||
| # no z-band in comCamSim | ||
| del config.atools.yPerpPSF | ||
| del config.atools.yPerpCModel |
There was a problem hiding this comment.
I didn't know it was this easy to remove a tool from a task. Cool!
I understand why this has to be here and not obs_lsst too: the pipeline yaml overrides get applied after the obs package ones.
| - photometricCatalogMatch | ||
| - photometricRefCatObjectTract | ||
| - refCatObjectTract | ||
| - validateObjectTableCore |
There was a problem hiding this comment.
Can we also add the plotPropertyMapTract task please.
There was a problem hiding this comment.
Its already a member of coaddQualityCore
taranu
force-pushed
the
tickets/DM-43049
branch
from
0d42b52
to
78ee970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds one task to ci_imsim for testing