DM-43033: Add fgcmcal to ComCamSim ops rehearsal pipeline #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
approved these changes
Mar 5, 2024
| @@ -9,6 +9,17 @@ imports: | |||
| - $ANALYSIS_TOOLS_DIR/pipelines/matchedVisitQualityCore.yaml | |||
| - $ANALYSIS_TOOLS_DIR/pipelines/visitQualityCore.yaml | |||
| tasks: | |||
| fgcmFitCycle: | |||
| class: lsst.fgcmcal.fgcmFitCycle.FgcmFitCycleTask | |||
| config: | |||
There was a problem hiding this comment.
Why not include these with the other configs in obs_lsst?
There was a problem hiding this comment.
By habit these are more of a "pipeline" thing and not a "config" thing. And if we define a starflat pipeline these are the most likely values to change.
erykoff
force-pushed
the
tickets/DM-43033
branch
from
d81e358
to
b519325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.