Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43347: Add a Fast Summit Support and a Slower Validation Pipelines to be run on Rapid Analysis #114

Merged
merged 1 commit into from Mar 21, 2024

Conversation

yalsayyad
Copy link
Contributor

Come to pair coding tomorrow to yell at me about how this doesn't look how you were expecting. 3/20 11am PT!

@yalsayyad yalsayyad force-pushed the tickets/DM-43347 branch 7 times, most recently from 6b8b62b to 6cc2b78 Compare March 20, 2024 22:30
Copy link
Member

@ctslater ctslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about comments, nothing substantial.

isr:
class: lsst.ip.isr.IsrTask
config:
# Turn off all slow steps in ISR for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken sentence

can be run together, but only after the 'step1' and 'step2d'
subsets.

These should be run with explicit 'tract' constraints essentially all the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? Seems like it'll be a pain if we have to select tracts for each night.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I totally agree, in case it helps, the log from the preliminaryVisitCoverageAnalysis task spits out this helpful message:

INFO 2024-03-20T14:49:25.907-07:00 lsst.analysis.tools.actions.plot.multiVisitCoveragePlot (preliminaryVisitCoverageAnalysis:{instrument: 'LSSTComCamSim', skymap: 'DC2'})(multiVisitCoveragePlot.py:363) - List of tracts overlapping data:  [6914, 6915, 9347, 9348, 3345, 3346, 7445, 7446, 9880, 9638, 3384, 3385, 2494, 2495, 3533, 9813, 2661, 2662, 7149, 9590, 9591]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true for this pipeline. That was copied and pasted from HSC-style. This pipeline we're embracing ragged style.

@@ -0,0 +1,87 @@
description: |
DRP-flavored pipeline to support validation
commissiong validation pipeline that will help inform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
commissiong validation pipeline that will help inform
during commissioning, and will help inform

- A fast observer-support pipeline matching what the
  single frame runner in the summit rapid analysis
  runs now. Working title = Quick Look
- A commissiong validation pipeline that will help inform
  what changes to make the following night. Detector and Visit
  level tasks can be run in real time by e.g. Rapid Analysis.
  The rest of the pipeline is expected to be run as part of the
  10am processing. Working title = Nightly Validation
@yalsayyad yalsayyad merged commit 381a52f into main Mar 21, 2024
3 checks passed
@yalsayyad yalsayyad deleted the tickets/DM-43347 branch March 21, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants