DM-30892: add BPS configuration snippets #31
Conversation
TallJimbo
force-pushed
the
tickets/DM-30892
branch
2 times, most recently
from
622a4a9
to
19a5ab4
Compare
bps/clustering/DRP-recalibrated.yaml
Outdated
| # Use it by adding: | ||
| # | ||
| # includeConfigs: | ||
| # - ${DRP_PIPE_DIR}/bps/clustering/DRP-recalibrated.yaml |
There was a problem hiding this comment.
Should this line be indented by one more whitespace? I.e., so that the - is directly below the c in includeConfigs?
| # (with no outer indentation) to your BPS config file. | ||
|
|
||
| clusterAlgorithm: lsst.ctrl.bps.quantum_clustering_funcs.dimension_clustering | ||
| cluster: |
There was a problem hiding this comment.
General comment: starting here, it seems like the rest of this file is using a tab indent of 4 spaces, whereas I think this needs to be 2 spaces (as with the other YAMLs in this PR).
There was a problem hiding this comment.
The yaml linter configuration just requires that we be consistent within a single file. Maybe we need to be a bit more draconian.
There was a problem hiding this comment.
I've just switched this file to 2-space indents for now.
bps/resources/HSC/DRP-RC2.yaml
Outdated
| # Use it by adding: | ||
| # | ||
| # includeConfigs: | ||
| # - ${DRP_PIPE_DIR}/bps/resources/HSC/DRP-RC2.yaml |
There was a problem hiding this comment.
Another indent required here too.
bps/resources/HSC/DRP-RC2.yaml
Outdated
| requestMemory: 10000 | ||
| consolidateForcedSourceOnDiaObjectTable: | ||
| requestMemory: 490000 | ||
| queue: "SLAC_Rubin_Merge" |
There was a problem hiding this comment.
Should this (queue: ...) live here in this file?
| # Use it by adding: | ||
| # | ||
| # includeConfigs: | ||
| # - ${DRP_PIPE_DIR}/bps/resources/LSSTCam-imSim/DRP-DP0.2.yaml |
There was a problem hiding this comment.
An extra indent is needed here too.
| # Use it by adding: | ||
| # | ||
| # includeConfigs: | ||
| # - ${DRP_PIPE_DIR}/bps/resources/LSSTCam-imSim/DRP-test-med-1.yaml |
There was a problem hiding this comment.
And one final indent is needed here too.
These are taken from three different github repos (all lsst-dm): dp02-processing/blob/main/full/production/step1/requestMemory.yaml gen3_bps_dc2/tree/main/weekly_templates/*.yaml gen3_bps_rc2/tree/main/weekly_templates/*.yaml I very much doubt they're complete, except perhaps the DP0.2 one, as the HSC/RC2 and DC2/test-med-1 each provide some values the other does not.
Tested on ci_hsc.
TallJimbo
force-pushed
the
tickets/DM-30892
branch
from
25de2f3
to
a1bd40a
Compare
No description provided.