DM-35207: update visit summaries and use them downstream #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-35207
branch
3 times, most recently
from
77e9c8b
to
c89abe3
Compare
Changes in pipe_tasks will take care of making existing tasks use this new task's outputs instead of the old visit summaries, so most of the changes here are about redefining subsets to be compatible with the new overall flow. Many of the DECam changes are actually removals of Gen2 config options that now do nothing (but previously did the equivalent of Gen3 connection changes).
Now that we're using the final Piff PSF measurements to drive coadd selection and other visit-summary-based things, we can switch back to PSFEx for speed and robustness for our first PSF model.
This pipeline is soon to be deprecated anyway, but since we're still nominally maintaining it it's useful to drop these tasks that don't serve a purpose there: they're all things that really only need to be run once, before the fakes are inserted, and rerunning them after the fakes have been inserted either doesn't change them or adds circular measurements (e.g. PSF summary stats on fakes inserted with the PSF model we're trying to summaries) that we don't.
TallJimbo
force-pushed
the
tickets/DM-35207
branch
2 times, most recently
from
4044996
to
71c4b24
Compare
laurenam
approved these changes
Jan 9, 2023
TallJimbo
force-pushed
the
tickets/DM-35207
branch
from
06d5fcc
to
71c4b24
Compare
This hasn't been the actual pipeline run for DP0.2 for a long time, and (unlike HSC's RC@) the ImSim test-med-1 pipeline is already just as suitable for large-scale productions (it differs only in which analysis plots/metrics are run).
TallJimbo
force-pushed
the
tickets/DM-35207
branch
from
71c4b24
to
623c28f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.