DM-37141: Switch to gbdesAstrometricFit #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
force-pushed
the
tickets/DM-37141
branch
3 times, most recently
from
cc57fe0
to
917a652
Compare
yalsayyad
approved these changes
Mar 6, 2023
| @@ -19,6 +19,8 @@ tasks: | |||
| class: lsst.jointcal.JointcalTask | |||
| config: | |||
| connections.inputSourceTableVisit: preSourceTable_visit | |||
| gbdesAstrometricFit: | |||
There was a problem hiding this comment.
Remove jointcal too. DRP-full.yaml should be a complete pipeline without redundant leaves that could in theory run from beginning to end (like in ci_hsc_gen3)
| @@ -44,6 +44,7 @@ tasks: | |||
| photo_calib_provider: "tract" | |||
| background_provider: "input_summary" | |||
| connections.photoCalibName: "jointcal" | |||
| connections.skyWcsName: "jointcal" | |||
There was a problem hiding this comment.
Up in line 13, I think you should exclude gbdesAstrometricFit along with fgcm.
| @@ -52,6 +53,7 @@ tasks: | |||
| modelPsf.defaultFwhm: 7.7 | |||
| warpAndPsfMatch.warp.warpingKernelName: lanczos5 | |||
| coaddPsf.warpingKernelName: lanczos5 | |||
| connections.skyWcsName: jointcal | |||
There was a problem hiding this comment.
and if you remove jointcal from DRP-Full.yaml, it needs to go here for DECam.
class: lsst.jointcal.JointcalTask
config:
connections.inputSourceTableVisit: preSourceTable_visit
cmsaunders
force-pushed
the
tickets/DM-37141
branch
from
917a652
to
edb61a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.