DM-35784: Update default truth match configuration #84
Conversation
taranu
force-pushed
the
tickets/DM-35784
branch
from
8ca595c
to
f687fc4
Compare
| @@ -69,7 +69,7 @@ tasks: | |||
| python: | | |||
| from lsst.pipe.tasks.diff_matched_tract_catalog import MatchedCatalogFluxesConfig | |||
| columns_flux = {} | |||
| for band in 'ugrizy': | |||
| for band in ("u", "g", "r", "i", "z", "y"): | |||
There was a problem hiding this comment.
If this is preferable, do you want to do it at lines 23 & 24 above?
config.astromRefObjLoader.filterMap = {band: 'lsst_%s_smeared' % (band) for band in 'ugrizy'};
config.photoRefObjLoader.filterMap = {band: 'lsst_%s_smeared' % (band) for band in 'ugrizy'};
There was a problem hiding this comment.
Better yet, I think I'll put the filterMap in parameters now that those can be referenced in python blocks.
| 'flux_i', 'flux_z', 'flux_y', | ||
| bands_match = ("u", "g", "r", "i", "z", "y") | ||
| # Bands to match aperture fluxes on as a fallback if cModel failed | ||
| bands_fallback = ("r", "i") |
There was a problem hiding this comment.
I didn't want to include every band because then the aperture fluxes would be weighted as much as the CModel fluxes for matching (there is no way to weight each column differently as of yet). It seems unlikely there are many good detections with only u/g aperture fluxes. I suppose there could be z-band dropouts but this was meant to fix a problem with brighter stars.
There was a problem hiding this comment.
Got it...a comment in the file would be nice.
| config.match_tract_catalog.columns_target_copy = ['objectId'] | ||
| config.match_tract_catalog.columns_ref_copy = ["id", "truth_type"] | ||
| config.match_tract_catalog.columns_ref_select_true = ["is_unique_truth_entry"] | ||
| config.match_tract_catalog.columns_target_copy = ["objectId"] |
There was a problem hiding this comment.
This file has a full-on mix-n-match of single vs. double quotes. Instead of updating these here, perhaps a separate commit to homogenize all those in the task overrides would be warranted?
No description provided.