Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add difference imaging steps to LATISS DRP.yaml #98

Merged
merged 3 commits into from Dec 6, 2023
Merged

Conversation

hlin730
Copy link
Contributor

@hlin730 hlin730 commented Dec 6, 2023

Add difference imaging tasks in step4, step5, and step6. Also modify step2bcde (move transformSourceTable, consolidateSourceTable, writeRecalibratedSourceTable from step4 to here) and step3b (add selectGoodSeeingVisits and templateGen).

Add difference imaging tasks in step4, step5, and step6.  Also modify step2bcde (move transformSourceTable, consolidateSourceTable, writeRecalibratedSourceTable from step4 to here) and step3b (add selectGoodSeeingVisits and templateGen).
Copy link
Member

@ctslater ctslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few thoughts to the yaml file; I think everything should work ok but there are a few tasks that might be better in different steps long term? I'm not super committed to that though, so open to discussion about these.

pipelines/LATISS/DRP.yaml Outdated Show resolved Hide resolved
pipelines/LATISS/DRP.yaml Show resolved Hide resolved
pipelines/LATISS/DRP.yaml Outdated Show resolved Hide resolved
pipelines/LATISS/DRP.yaml Outdated Show resolved Hide resolved
After review, move some tasks for consistency with HSC DRP-RC2.yaml:  selectGoodSeeingVisits and templateGen to step3a, writeRecalibratedSourceTable and transformSourceTable to step4, consolidateSourceTable to step5.
Fix trailing space linting error in line 252.
Copy link
Member

@ctslater ctslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hlin730 hlin730 merged commit 90293e7 into main Dec 6, 2023
3 checks passed
@hlin730 hlin730 deleted the tickets/DM-39038 branch December 6, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants