Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39221: Move ForcedPhotCoaddTask from meas_base #15

Merged
merged 1 commit into from May 25, 2023
Merged

Conversation

fred3m
Copy link
Contributor

@fred3m fred3m commented May 23, 2023

No description provided.

Copy link
Collaborator

@cmsaunders cmsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine--there are just some places where the docs need to be updated, and I had a question about the dunder-init files.

@@ -0,0 +1,49 @@
.. lsst-task-topic:: lsst.drp.pipe.forcedPhotCoadd.ForcedPhotCoaddTask
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change pipe to tasks.

A ``Coadd_forced_src`` variant (e.g. ``deepCoadd_forced_src``)
The resulting measurement catalog.

.. _lsst.drp.pipe.forcedPhotCoadd.ForcedPhotCoaddTask-api:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Python API summary
==================

.. lsst-task-api-summary:: lsst.meas.base.forcedPhotCoadd.ForcedPhotCoaddTask
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update


.. lsst-task-api-summary:: lsst.meas.base.forcedPhotCoadd.ForcedPhotCoaddTask

.. _lsst.drp.pipe.forcedPhotCoadd.ForcedPhotCoaddTask-subtasks:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

Retargetable subtasks
=====================

.. lsst-task-config-subtasks:: lsst.meas.base.forcedPhotCoadd.ForcedPhotCoaddTask
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update


.. lsst-task-config-subtasks:: lsst.meas.base.forcedPhotCoadd.ForcedPhotCoaddTask

.. _lsst.drp.pipe.forcedPhotCoadd.ForcedPhotCoaddTask-configs:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

Configuration fields
====================

.. lsst-task-config-fields:: lsst.meas.base.forcedPhotCoadd.ForcedPhotCoaddTask
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update...probably should have just said update all instances of meas.base or drp.pipe in my first comment!

@@ -0,0 +1,2 @@
import pkgutil
__path__ = pkgutil.extend_path(__path__, __name__)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sort of thought we didn't need to have all the init.py files anymore, but I can't remember where I got that idea. Is this necessary for the documentation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a discussion about this on DM-20979. Currently they are better off being there.

@fred3m fred3m merged commit 7457645 into main May 25, 2023
1 check passed
@fred3m fred3m deleted the tickets/DM-39221 branch May 25, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants