DM-30895: Move AssembleCoaddTask and its children from pipe_tasks #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
changed the title
fred3m
requested changes
Sep 13, 2023
| self.doUsePsfMatchedPolygons = True | ||
|
|
||
| # Real EDGE removed by psfMatched NO_DATA border half the width of the | ||
| # matching kernel CompareWarp applies psfMatched EDGE pixels to |
There was a problem hiding this comment.
insert period after "kernel".
|
|
||
| Parameters | ||
| ---------- | ||
| spanSetList : `list` [`lsst.afw.geom.SpanSet`] |
There was a problem hiding this comment.
I think that this should match the type hints syntax list[lsst.afw.geom.SpanSet]. Same with all other docstrings in this PR.
There was a problem hiding this comment.
The above is correct. Sphinx can't parse type annotations so you have to backtick quote each type separately.
Comment on lines
1060
to
1099
| @staticmethod | ||
| def _subBBoxIter(bbox, subregionSize): | ||
| """Iterate over subregions of a bbox. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| bbox : `lsst.geom.Box2I` | ||
| Bounding box over which to iterate. | ||
| subregionSize : `lsst.geom.Extent2I` | ||
| Size of sub-bboxes. | ||
|
|
||
| Yields | ||
| ------ | ||
| subBBox : `lsst.geom.Box2I` | ||
| Next sub-bounding box of size ``subregionSize`` or smaller; each | ||
| ``subBBox`` is contained within ``bbox``, so it may be smaller than | ||
| ``subregionSize`` at the edges of ``bbox``, but it will never be | ||
| empty. | ||
|
|
||
| Raises | ||
| ------ | ||
| RuntimeError | ||
| Raised if any of the following occur: | ||
| - The given bbox is empty. | ||
| - The subregionSize is 0. | ||
| """ | ||
| if bbox.isEmpty(): | ||
| raise RuntimeError("bbox %s is empty" % (bbox,)) | ||
| if subregionSize[0] < 1 or subregionSize[1] < 1: | ||
| raise RuntimeError("subregionSize %s must be nonzero" % (subregionSize,)) | ||
|
|
||
| for rowShift in range(0, bbox.getHeight(), subregionSize[1]): | ||
| for colShift in range(0, bbox.getWidth(), subregionSize[0]): | ||
| subBBox = geom.Box2I(bbox.getMin() + geom.Extent2I(colShift, rowShift), subregionSize) | ||
| subBBox.clip(bbox) | ||
| if subBBox.isEmpty(): | ||
| raise RuntimeError("Bug: empty bbox! bbox=%s, subregionSize=%s, " | ||
| "colShift=%s, rowShift=%s" % | ||
| (bbox, subregionSize, colShift, rowShift)) | ||
| yield subBBox |
There was a problem hiding this comment.
This is in lsst.pipe.tasks.coaddBase, so it can be removed as a static method of this class.
in the preamble.
arunkannawadi
force-pushed
the
tickets/DM-30895
branch
from
7cd2876
to
cb3650c
Compare
|
Great catches, Fred! I've addressed the comments now.
|
arunkannawadi
force-pushed
the
tickets/DM-30895
branch
from
cb3650c
to
04fc343
Compare
fred3m
approved these changes
Sep 19, 2023
File(s) transferred:
- python/lsst/pipe/tasks/assembleCoadd.py ->
python/lsst/pipe/tasks/assemble_coadd.py
File(s) transferred:
- python/lsst/pipe/tasks/dcrAssembleCoadd.py ->
python/lsst/pipe/tasks/dcr_assemble_coadd.py
Files transferred: - python/lsst/pipe/tasks/assembleChi2Coadd.py -> python/lsst/drp/tasks/assemble_chi2_coadd.py
File(s) transferred:
- tests/assembleCoaddUtils.py ->
tests/_assemble_coadd_utils.py
File(s) transferred:
- tests/test_assembleCoadd.py ->
tests/test_assemble_coadd.py
- tests/test_dcrAssembleCoadd.py ->
tests/test_dcr_assemble_coadd.py
arunkannawadi
force-pushed
the
tickets/DM-30895
branch
from
04fc343
to
51078aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.