DM-41634: Switch initial WCS to AST #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Nov 30, 2023
timj
approved these changes
Nov 30, 2023
| @@ -708,7 +708,12 @@ def _get_exposure_info( | |||
| extensionType.append("SCIENCE") | |||
|
|
|||
| wcs = row.getWcs() | |||
| wcss.append(_get_wcs_from_sip(wcs)) | |||
There was a problem hiding this comment.
I think you can delete the _get_wcs_from_sip function completely now.
There was a problem hiding this comment.
I'm reluctant to remove this, as it was a pain to get it working properly and I'm not 100% certain it won't be needed in the future.
There was a problem hiding this comment.
Isn't that what git is for though? Otherwise it's untested code that is going to bit rot anyhow.
There was a problem hiding this comment.
Yeah, assuming I remember...I'll remove it.
cmsaunders
force-pushed
the
tickets/DM-41634
branch
from
cf5f8dc
to
2f95862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.