DM-37417: Remove random ordering #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
approved these changes
Dec 20, 2022
| @@ -345,6 +346,11 @@ class GbdesAstrometricFitConfig(pipeBase.PipelineTaskConfig, | |||
| doc="Exclude reference objects without proper motion/parallax information.", | |||
| default=True | |||
| ) | |||
| fitReserveRandomSeed = pexConfig.Field( | |||
| dtype=int, | |||
| doc="Set the random seed for selecting data points to reserve from the fit for validate.", | |||
| inputVisitSummary : `list` of `lsst.afw.table.ExposureCatalog` | ||
| List of catalogs with per-detector summary information. | ||
| inputVisitSummary : `lsst.afw.table.ExposureCatalog` | ||
| Catalogs with per-detector summary information. |
There was a problem hiding this comment.
Should this be single Catalog?
| @@ -967,7 +979,7 @@ def _add_objects(self, wcsf, inputCatalogRefs, sourceIndices, extensionInfo, col | |||
| for inputCatalogRef in inputCatalogRefs: | |||
| visit = inputCatalogRef.dataId['visit'] | |||
| inputCatalog = inputCatalogRef.get(parameters={'columns': columns}) | |||
| detectors = set(inputCatalog['detector']) | |||
| detectors = np.unique(inputCatalog['detector']) | |||
There was a problem hiding this comment.
Please add a comment that np.unique will output a sorted ordering of detector?
tests/test_gbdesAstrometricFit.py
Outdated
| @@ -500,6 +504,8 @@ def test_run(self): | |||
| fitYPoly = fitModel[len(origXPoly):] | |||
| absDiffX = abs(fitXPoly - origXPoly) | |||
| absDiffY = abs(fitYPoly - origYPoly) | |||
| print(absDiffX) | |||
| print(absDiffY) | |||
There was a problem hiding this comment.
These print statements should go.
cmsaunders
changed the title
This also sets the random number seed in the tests to ensure repeatability.
cmsaunders
force-pushed
the
tickets/DM-37417
branch
from
28613af
to
98f9dd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.