DM-43771: disable warping kernel caching and make sure we do PSF-evaluation caching. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-43771
branch
from
fe87a63
to
9d9234b
Compare
arunkannawadi
approved these changes
Apr 15, 2024
| # to evaluate the PSF twice, which is more than enough since many don't | ||
| # evaluate it at all, and there's no *good* reason for any algorithm to | ||
| # evaluate it more than once. | ||
| exposure.psf.setCacheCapacity(2 * len(self.config.measurement.plugins.names)) |
There was a problem hiding this comment.
Is the rationale for 2 here is to cache the resulting image from calling computeImage and computeKernelImage?
There was a problem hiding this comment.
No, those are already separate caches, so they effectively already have that factor of two. I'm just being defensive against plugins doing more PSF evaluations than they probably should.
TallJimbo
force-pushed
the
tickets/DM-43771
branch
from
9d9234b
to
3bfb96c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.