DM-37786: utilize fine-grained control over QG generation behavior to work around limitations there #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Feb 14, 2023
UpdateVisitSummaryTask can take inputs that include the {tract}
dimension, which can impose an undesirable spatial constraint on its
{visit, detector} inputs when only one tract (or a few disjoint tracts)
are being processed. Using deferGraphConstraint here sets the default
behavior of the pipetask --dataset-query-constraint option such that
users don't have to use it to get the right behavior for this task (and
other tasks being run with it).
I'm also using deferGraphConstraint on many other connections here as
an optimization, which is something we could start doing in more tasks,
whenever we can be reasonably confident that some other dataset's
existence (here visitSummary) will provide an equivalent constraint.
TallJimbo
force-pushed
the
tickets/DM-37786
branch
from
271332c
to
e9eed1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.