Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added patch for eigen bug 1086, to support new SuiteSparse #1

Merged
merged 1 commit into from Feb 29, 2016

Conversation

parejkoj
Copy link
Contributor

Apply a tweaked version of the the patch in eigen ticket 1086:

http://eigen.tuxfamily.org/bz/show_bug.cgi?id=1086

to solve the UF_fact that long doesn't exist in newer versions of SuiteSparse.

@timj
Copy link
Member

timj commented Feb 29, 2016

I looked at the ticket branch in my git checkout and there were five commits. Checking it out again moves it to one. I think I would have preferred two commits (one for the upstream patch and one for the local tweaks) but I'm not overly bothered.

@parejkoj
Copy link
Contributor Author

Good point about two commits. Sadly, I can't "unsquash".

If you're happy with it, I'll merge.

@RobertLuptonTheGood
Copy link
Member

Aren't the old change sets still in the reflog?

    R

On 29 Feb 2016, at 18:28, John Parejko notifications@github.com wrote:

Good point about two commits. Sadly, I can't "unsquash".

If you're happy with it, I'll merge.


Reply to this email directly or view it on GitHub.

parejkoj added a commit that referenced this pull request Feb 29, 2016
Added patch plus tweaks for eigen bug 1086, to support new SuiteSparse
@parejkoj parejkoj merged commit 70497dd into master Feb 29, 2016
@timj
Copy link
Member

timj commented Feb 29, 2016

Yes: d30c091

@parejkoj
Copy link
Contributor Author

Oh, I just merged this. Should I go back and sort that out? I expect that what will actually happen in the future is we'll upgrade to eigen 3.3 when it is released, and just delete the patch.

@timj
Copy link
Member

timj commented Mar 1, 2016

Leave it now. No one wants to force push to master...

@ktlim ktlim deleted the tickets/DM-5183 branch August 25, 2018 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants