DM-18895: upgrade to 3.3.7, apply cholmod patch #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch mostly consists of commit 9cb9646c471878cd6843bcf5a272410121360b9c made to master after the 3.3 branch was made. It also contains all other changes to CholmodSupport.h between 3.3.4 and master. This allows us to use cholmod with std::ptrdiff_t indices.
Because we can. It's just a patch release. Removing the cmake patches because they appear to have been applied in the upgrade.
|
Formal submission, replaces proposal in #6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.