DM-32229: Update faro TExTasks to take parquet table as input #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able column names
edennihy
changed the title
psferguson
reviewed
Dec 6, 2021
added 2 commits
December 7, 2021 07:19
psferguson
approved these changes
Dec 14, 2021
bechtol
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Thanks for all the work on this PR, including the validation tests / comparisons between the FITS and parquet input versions. Suggest to move forward to merge this ticket so that we have a concrete example of a measurement task that uses the parquet table inputs while we continue to develop the strategy to implement selectors and specify columns to load from the parquet tables across various metrics and analysis contexts.
|
second jenkins job after requested pr changes -> https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35623/pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins job -> https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35491/pipeline
This also resulted in a few minor changes to tex.py and some of its dependencies, see notes in JIRA ticket (https://jira.lsstcorp.org/browse/DM-32229)