DM-26987: Update filtering of matched catalog to operate before creating GroupView #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctslater
reviewed
Jan 27, 2022
pipelines/preparation/preparation_matched_multi_jointcal_fgcm.yaml
Outdated
Show resolved
Hide resolved
| faintMagCut: 21.5 | ||
| selectExtended: False | ||
| python: | | ||
| config.connections.outputCatalog = 'matchedCatalogTractMag17to21p5' |
There was a problem hiding this comment.
I couldn't deduce what the p5 means.
There was a problem hiding this comment.
That's my shorthand for 21.5, since I don't want to put the '.' in there...
|
Jenkins job kicked off here |
leannep
approved these changes
Jan 29, 2022
jeffcarlin
force-pushed
the
tickets/DM-26987
branch
from
37ce503
to
90e9d96
Compare
|
Successful Jenkins run here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented filtering of catalogs before running multiMatch to create the matched catalogs. This involved:
a) writing a new "prefilter" function, which is called from matcher.py
b) adding config params to control the filtering to the base matched catalog class
c) re-writing some pipelines to allow for different cuts to be applied for different metrics (e.g., the "default" SNR cut for photometric repeatability, but magnitude ranges for astrometric repeatability)
Part (c) has the effect of writing additional matched catalogs rather than using the same one for all metrics. However, I thought it was worth the extra steps to make the entire pipeline more efficient. We could reconsider this if needed.
Some simple tests suggest that for small amounts of data, pipelines with prefiltering of catalogs before matching run in ~half the time, and use ~half the memory. It's possible that the effect will be more dramatic when processing large chunks of data.