Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31611: Improve reproducibility in ellipKPM test_te1 #119

Merged
merged 1 commit into from Jan 31, 2022
Merged

DM-31611: Improve reproducibility in ellipKPM test_te1 #119

merged 1 commit into from Jan 31, 2022

Conversation

ctslater
Copy link
Member

Passing the brute-force parameter to treecorr ensures that the numerical answers in tests are the same across different
machine architectures.

@ctslater
Pass brute-force parameter to treecorr in unit tests.
8e3634e 
This ensures that the numerical answers in tests are the same across different
machine architectures.
erykoff
erykoff approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the only one that needs this?

@ctslater
Copy link
Member Author

Good point. After looking, test_tex_util.py has a test which directly passes brute=True. That's the only other test that calls treecorr.

@ctslater ctslater merged commit 7d5ea35 into main Jan 31, 2022
@bechtol bechtol mentioned this pull request Mar 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctslater @erykoff