DM-34168: Use only deblended primary sources for TEx metrics #130
Conversation
| @@ -74,7 +75,7 @@ def test_te1(self): | |||
| result = task.run('TE1', {'i': [CalibratedCatalog(catalog), ]}) | |||
| log.debug('result: ', result) | |||
| log.debug('expected: ', expected) | |||
| self.assertAlmostEqual(result.measurement, expected, places=10) | |||
| np.testing.assert_almost_equal(result.measurement.quantity, expected.quantity, decimal=5) | |||
There was a problem hiding this comment.
What's the reason to switch to numpy testing here? I would have thought it made sense for arrays, but that doesn't seem to be the case.
There was a problem hiding this comment.
Perhaps, you could add the reason in the body of the commit message? https://developer.lsst.io/work/flow.html?highlight=commit#writing-commit-message-body-content
There was a problem hiding this comment.
Sure. FYI it's because assertAlmostEqual doesn't actually work for lsst.verify.measurement.Measurementobjects (since it doesn't have subtraction defined). Unfortunately assertAlmostEqual doesn't work with astropy.quantity.Quantity values either, so I had to both extract the quantity and use numpy's almost equal. 😞
| @@ -74,7 +75,7 @@ def test_te1(self): | |||
| result = task.run('TE1', {'i': [CalibratedCatalog(catalog), ]}) | |||
| log.debug('result: ', result) | |||
| log.debug('expected: ', expected) | |||
| self.assertAlmostEqual(result.measurement, expected, places=10) | |||
| np.testing.assert_almost_equal(result.measurement.quantity, expected.quantity, decimal=5) | |||
There was a problem hiding this comment.
Perhaps, you could add the reason in the body of the commit message? https://developer.lsst.io/work/flow.html?highlight=commit#writing-commit-message-body-content
fred3m
force-pushed
the
tickets/DM-34168
branch
from
49eb493
to
ab9c182
Compare
`assertAlmostEqual` doesn't actually work for `lsst.verify.measurement.Measurement` objects (since the class doesn't have subtraction defined). Unfortunately `assertAlmostEqual` doesn't work with `astropy.quantity.Quantity` values either, so we are forced to both extract the quantity and use numpy's almost equal.
fred3m
force-pushed
the
tickets/DM-34168
branch
from
ab9c182
to
6ed74f6
Compare
No description provided.