DM-33892: Add TractTableValueMeasurementTask #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
force-pushed
the
tickets/DM-33892
branch
2 times, most recently
from
7053225
to
c8ae0d0
Compare
bechtol
reviewed
May 18, 2022
| for column in columns_base) | ||
|
|
||
| # TODO: does it make sense to validate this now or just leave it to the run call? | ||
| # assert all(column in inputs['columns'] for column in columns_in) |
There was a problem hiding this comment.
Perhaps this check is more appropriate here? It seems more like a validation of the formatting of the inputs to the run method rather than something fundamental to the calculation itself.
There was a problem hiding this comment.
Ah sorry, I should clarify - if any of columns_in are not in the table, then the call to inputs['table'].get(parameters={'columns': columns_in}) three lines later will fail. So I figured there's not really any point in duplicating a check that the get method does.
bechtol
approved these changes
May 18, 2022
taranu
force-pushed
the
tickets/DM-33892
branch
2 times, most recently
from
d2c17dd
to
a62c4eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.