DM-39828: Use 'Catalog.__getitem__' instead of 'get' in selectors. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
approved these changes
Jul 3, 2023
| @@ -86,7 +86,7 @@ def averageRaDecFromCat(cat): | |||
| dec_mean : `float` | |||
| Mean Dec in radians. | |||
| """ | |||
| return averageRaDec(cat.get("coord_ra"), cat.get("coord_dec")) | |||
| return averageRaDec(cat["coord_ra"], cat["coord_dec"]) | |||
There was a problem hiding this comment.
The docstring for cat says that it must have a get method. Should that be changed to say __getitem__ that can accept 'coord_ra' and 'coord_dec'? Similarly for averageRaFromCat and averageDecFromCat.
'get' actually invokes the ColumnView method via __getattr__ forwarding, and that's less capable than Catalog.__getitem__ as well as being a pointless forward to ColumnView.__getitem__ that probably never needed to exist.
TallJimbo
force-pushed
the
tickets/DM-39828
branch
from
eea7b0a
to
7f1b104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'get' actually invokes the ColumnView method via getattr forwarding, and that's less capable than Catalog.getitem as well as being a pointless forward to ColumnView.getitem that probably never needed to exist.