Fix errors introduced in previous rebase. #86
Conversation
| @@ -2,7 +2,7 @@ description: Complete metrics measurement pipeline | |||
| imports: | |||
| - location: $FARO_DIR/pipelines/metrics_pipeline_matched.yaml | |||
| - location: $FARO_DIR/pipelines/metrics_pipeline_matched_multi.yaml | |||
| - location: $FARO_DIR/pipelines/metrics_pipeline_visit.yaml | |||
| # - location: $FARO_DIR/pipelines/metrics_pipeline_visit.yaml | |||
There was a problem hiding this comment.
We shouldn't leave commented out code, even in yaml files, I don't think.
There was a problem hiding this comment.
Agreed - I think (and Dan T.'s questions in the thread on #dm-hsc-reprocessing are reminding me) that we need to settle on a standard set of pipelines, and add documentation (perhaps in the .yaml itself?) to explain what setting each pipeline is meant for. Otherwise we have a "main" pipeline in which we comment/uncomment things as needed.
There was a problem hiding this comment.
Will create a separate ticket to reorganize and improve documentation/readability of pipelines.
| @@ -3,5 +3,7 @@ tasks: | |||
| matchCatalogsPatchMultiBand: | |||
| class: lsst.faro.preparation.PatchMatchedMultiBandPreparationTask | |||
| config: | |||
| connections.photoCalibName: fgcm_photoCalib | |||
| apply_external_wcs: True # We only support jointcal for now | |||
| python: | | |||
There was a problem hiding this comment.
Looking over the pipeline used by validate_drp_gen3, I don't think this will break that, but just want to make sure.
There was a problem hiding this comment.
Oh, good point. I'll look up what validate_drp_gen3 uses.
Minor edits to fix changes that got missed during rebase/merge of DM-29841.