Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm 16556 #87

Merged
merged 4 commits into from May 26, 2021
Merged

Tickets/dm 16556 #87

merged 4 commits into from May 26, 2021

Conversation

jeffcarlin
Copy link
Collaborator

This was indeed a bug in the indexing, so that all of our matched-catalog astrometry KPMs were selecting the wrong set of sources. I confirmed that this fix selects the correct sources.

@jeffcarlin jeffcarlin requested a review from leannep May 25, 2021 18:06
Copy link
Member

@leannep leannep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added some documentation cleanup to the ticket as well.

@leannep
Copy link
Member

leannep commented May 26, 2021

One more bug I just just noticed, the separations.py file has:
all = ("astromRms", "astromRms", "calcRmsDistances", "calcSepOutliers",
"matchVisitComputeDistance", "calcRmsDistancesVsRef")
"astromRms" is there twice. One of these should be changed to "astromResiduals"

@jeffcarlin jeffcarlin merged commit 998df38 into master May 26, 2021
@jeffcarlin jeffcarlin deleted the tickets/DM-16556 branch May 26, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants