Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37744: Make felis compatible with sqlalchemy 2 #18

Merged
merged 4 commits into from Feb 11, 2023
Merged

Conversation

andy-slac
Copy link
Contributor

Few small changes to make it work with both 1.4 and 2.0, plus mypy updates for new sqlalchemy.

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 97.92% // Head: 97.93% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (58065d5) compared to base (4b373c4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   97.92%   97.93%   +0.01%     
==========================================
  Files           6        6              
  Lines         386      388       +2     
==========================================
+ Hits          378      380       +2     
  Misses          8        8              
Impacted Files Coverage Δ
tests/test_sql.py 96.10% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you also please run pre-commit autoupdate to update the pre-commit configuration? (and maybe add a flake8 section to it copied from daf_butler)

@andy-slac andy-slac merged commit 8b088a5 into main Feb 11, 2023
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-37744 branch February 1, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants