DM-40675: Implement schema version specification for RFC-954 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 97.96% 98.12% +0.16%
==========================================
Files 6 6
Lines 393 427 +34
==========================================
+ Hits 385 419 +34
Misses 8 8
☔ View full report in Codecov by Sentry. |
timj
reviewed
Sep 14, 2023
.pre-commit-config.yaml
Outdated
| @@ -7,8 +7,9 @@ repos: | |||
| - "--unsafe" | |||
| - id: end-of-file-fixer | |||
| - id: trailing-whitespace | |||
| exclude: "README.md" | |||
| - repo: https://github.com/psf/black | |||
There was a problem hiding this comment.
Note that black now has a specialist repo for pre-commit at https://github.com/psf/black-pre-commit-mirror
timj
reviewed
Sep 14, 2023
.pre-commit-config.yaml
Outdated
| @@ -22,6 +23,6 @@ repos: | |||
| - id: isort | |||
| name: isort (python) | |||
| - repo: https://github.com/PyCQA/flake8 | |||
andy-slac
force-pushed
the
tickets/DM-40675
branch
from
651a535
to
719673f
Compare
README defines the structure for `version` keyword that can be either a simple string or a structure specifying version compatibility. Visitor classes are extended to handle version information, for now only the `SimpleVisitor` converts version info into a usable structure.
andy-slac
force-pushed
the
tickets/DM-40675
branch
from
719673f
to
aa09a2a
Compare
timj
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README defines the structure for
versionkeyword that can be either asimple string or a structure specifying version compatibility. Visitor
classes are extended to handle version information, for now only the
SimpleVisitorconverts version info into a usable structure.Plus some code cleanup and ruff checks for docstrings.