New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-41289: Make Felis fully pip installable #27
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 98.47% 92.68% -5.80%
==========================================
Files 7 18 +11
Lines 592 1915 +1323
Branches 0 379 +379
==========================================
+ Hits 583 1775 +1192
- Misses 9 86 +77
- Partials 0 54 +54 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay. Some minor comments.
Since this is a draft I will comment rather than approve. It looks like you need to look at the setup.cfg
file and make sure that you have everything moved across (and then delete everything in it apart of the flake8 section which has to stay. The empty pytest config needs to move to pyproject.toml as well.
6424fac
to
13c7ea2
Compare
I moved all the configuration from The PR should be ready for review now. |
c063831
to
0b2bcf5
Compare
691d4f7
to
5a360ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really qualified to review pip-installability.
Tim's comments seem appropriate, so I look forward to a reply on those.
ff3e140
to
76020e7
Compare
Configuration was updated so that felis will be pip installable using: pip install felis The DM developer documentation was used for guidance: https://developer.lsst.io/stack/building-with-pip.html Existing configuration was moved from setup.cfg to pyproject.toml where relevant.
A new job was added to the build.yaml workflow for publishing to PyPI. A few minor corrections and additions were made to the existing job for building and running the tests.
76020e7
to
7014ae9
Compare
I am merging without status checks passing because:
|
I fixed the repo configuration to remove python 3.10 and prevent the required checks from being overridden. |
Configuration was updated so that felis will be pip installable using:
The DM developer documentation was used for guidance:
https://developer.lsst.io/stack/building-with-pip.html
Existing configuration was moved from setup.cfg to pyproject.toml where relevant.
A new job was added to
build.yaml
which publishes the package to PyPI.A valid token needs to be added as a project secret called
PYPI_UPLOADS
for the publication to work.