DM-42293: Modify TAP visitor so constraints do not depend on column order #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 92.68% 92.71% +0.02%
==========================================
Files 18 18
Lines 1915 1921 +6
Branches 379 380 +1
==========================================
+ Hits 1775 1781 +6
Misses 86 86
Partials 54 54 ☔ View full report in Codecov by Sentry. |
JeremyMcCormick
force-pushed
the
tickets/DM-42293
branch
from
433d2cd
to
143ca88
Compare
The TapLoadingVisitor was modified so that constraints are created in a second pass over the schema. This ensures that columns which may be referenced have been defined. The change was tested successfully using "load-tap" from the command line, with and without the "--dry-run" argument. The TAP data loaded into a MySQL database correctly when using the non-mock connection.
JeremyMcCormick
force-pushed
the
tickets/DM-42293
branch
from
143ca88
to
c9a2070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TapLoadingVisitor was modified so that constraints are created in a second pass over the schema. This ensures that columns which may be referenced have been defined. The change was tested successfully using "load-tap" from the command line, with and without the "--dry-run" argument. The TAP data loaded into a MySQL database correctly when using the non-mock connection. The schema from this PR was used for testing.