DM-42291: Provide a default argument for schema renumbering to modify-tap command #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 92.61% 92.61% -0.01%
==========================================
Files 18 18
Lines 1951 1949 -2
Branches 381 380 -1
==========================================
- Hits 1807 1805 -2
Misses 87 87
Partials 57 57 ☔ View full report in Codecov by Sentry. |
gpdf
approved these changes
Feb 2, 2024
Add a default of 0 so that a TypeError does not occur when the "--start-schema-at" option is unspecified.
Adding a reasonable default makes this unnecessary.
JeremyMcCormick
force-pushed
the
tickets/DM-42291
branch
from
4ebf836
to
e7043a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a default of 0 so that a TypeError does not occur when the "--start-schema-at" option is unspecified.