DM-42787: Process constraints after tables are created in SQL visitor #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When constraints are processed in order, the use of forward references to columns will cause an exception, as they have not been visited and created yet. Instead, the visitor is changed so that the tables are processed first and then these referenced columns will be available when creating constraints.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 92.61% 92.62% +0.01%
==========================================
Files 18 18
Lines 1949 1952 +3
Branches 380 381 +1
==========================================
+ Hits 1805 1808 +3
Misses 87 87
Partials 57 57 ☔ View full report in Codecov by Sentry. |
gpdf
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constraints are processed in order, the use of forward references to columns will cause an exception, as they have not been visited and created yet. Instead, the visitor is changed so that the tables are processed first and then these referenced columns will be available when creating constraints.