DM-42446: Implement minor fixes and improvements to Python syntax #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 93.35% 93.36%
=======================================
Files 20 20
Lines 2092 2110 +18
Branches 420 425 +5
=======================================
+ Hits 1953 1970 +17
- Misses 80 81 +1
Partials 59 59 ☔ View full report in Codecov by Sentry. |
andy-slac
approved these changes
Feb 15, 2024
tests/test_cli.py
Outdated
| cli, ["validate", "--require-description", TEST_YAML], catch_exceptions=False | ||
| ) | ||
| except Exception as e: | ||
| print(e) |
There was a problem hiding this comment.
Hmm, you probably want to rethrow the exception here, so that test fails. Schema.require_description(False) should go into finally then.
There was a problem hiding this comment.
Good catch. I've made the change as you suggested.
This make changes suggested in review comments here: #31 (review) The PR was closed and merged before the review occurred, so this is being done on a separate branch.
This adds some tests for checking descriptions when the require_description flag is on for the default model.
JeremyMcCormick
force-pushed
the
tickets/DM-42446-andys-review
branch
from
ddb8412
to
5f0c332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make changes suggested in review comments here. The original PR was closed and merged before the second review occurred, so this is being done on a separate branch. All comments on the original PR should be resolved.
I made an additional change which was adding
from __future__ import annotationsto all of the Python files where it was missing.I also added a few more simple tests in
test_datamodel.pythat check for various errors on the description field when therequire_descriptionflag is turned on.