Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve sqlalchemy deprecation warning #42

Merged
merged 1 commit into from Feb 16, 2024
Merged

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Feb 16, 2024

Import declarative_base from new module to resolve sqlalchemy deprecation warning.

Warning message was:

felis/tap.py:44: MovedIn20Warning: The ``declarative_base()`` function is now available as sqlalchemy.orm.declarative_base(). (deprecated since: 2.0) (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)

Import declarative_base from new module to resolve sqlalchemy
deprecation warning.
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32cef69) 93.36% compared to head (3d265f8) 93.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   93.36%   93.36%   -0.01%     
==========================================
  Files          20       20              
  Lines        2110     2109       -1     
  Branches      425      425              
==========================================
- Hits         1970     1969       -1     
  Misses         81       81              
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. General comment - in middleware we are avoiding the use of SQLAlchemy ORM, and only using core part of it. I guess a limited use of ORM in felis should be fine.

@JeremyMcCormick JeremyMcCormick merged commit baa0b54 into main Feb 16, 2024
10 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-41824 branch February 16, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants