DM-43040: Add command line options for setting log level and file #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 93.36% 93.28% -0.08%
==========================================
Files 20 20
Lines 2109 2114 +5
Branches 425 428 +3
==========================================
+ Hits 1969 1972 +3
- Misses 81 82 +1
- Partials 59 60 +1 ☔ View full report in Codecov by Sentry. |
|
Can you consider using option names that match what we use in butler? |
Yes, I can change the CL options to |
JeremyMcCormick
force-pushed
the
tickets/DM-43040
branch
from
5bf1c58
to
93c9d0a
Compare
Two command line options are added for setting the Felis log level and, optionally, an output file for log messages. The log level is set using the "log-level" option and the output file using "log-file." These should match similar options in the lsst/daf_butler repo.
JeremyMcCormick
force-pushed
the
tickets/DM-43040
branch
from
93c9d0a
to
ebd4d21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two command line options are added for setting the Felis log level and, optionally, an output file for log messages.
To set these using command line options:
And they may also be set using environment variables:
These settings apply to the root logger which will also affect the child loggers. Different settings for each module logger are probably not needed right now.