DM-43751: Change default type mapping for boolean to BOOLEAN for MySQL #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyMcCormick
force-pushed
the
tickets/DM-43751
branch
from
384130e
to
b31e9aa
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-43751
branch
from
b31e9aa
to
de6d5e8
Compare
gpdf
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Felis currently maps the boolean type to
BIT(1)in MySQL, but it would be better to use its standardBOOLEANdatatype instead. This would make the usage ofmysql:datatype: BOOLEANin some of the columns a redundant override that should be removed, which is intended.BOOLEANtype