DM-43998: Properly validate default values and fix their handling in SQL metadata #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyMcCormick
force-pushed
the
tickets/DM-43998
branch
5 times, most recently
from
ef57f1b
to
1151625
Compare
JeremyMcCormick
changed the title
JeremyMcCormick
force-pushed
the
tickets/DM-43998
branch
3 times, most recently
from
5dc6957
to
5005bef
Compare
andy-slac
reviewed
Apr 25, 2024
JeremyMcCormick
force-pushed
the
tickets/DM-43998
branch
from
5005bef
to
a7cdc35
Compare
timj
reviewed
Apr 25, 2024
JeremyMcCormick
force-pushed
the
tickets/DM-43998
branch
2 times, most recently
from
b8c5e8b
to
5b6c6b9
Compare
JeremyMcCormick
commented
Apr 25, 2024
andy-slac
approved these changes
Apr 25, 2024
andy-slac
reviewed
Apr 25, 2024
JeremyMcCormick
force-pushed
the
tickets/DM-43998
branch
from
5b6c6b9
to
03ebd9d
Compare
This adds validation of the column `value` field, which provides a default that is passed to `server_default` when creating a SQLAlchemy column. The `MetaDataBuilder` was updated to properly handle these values depending on their type and content. Strings are quoted, except when they represent SQL functions such as `CURRENT_TIMESTAMP`. Tests were added to check that the validation functions properly for all of the Felis datatypes.
JeremyMcCormick
force-pushed
the
tickets/DM-43998
branch
from
03ebd9d
to
8bcdae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the handling of the
valuefield when creating SQLAlchemy metadata. String literals are quoted, except when the value is a SQL function such asCURRENT_TIMESTAMP. In this case, quotes are omitted.A thorough validation function was also added to the data model for checking
valueif it was provided. This will make sure that the provided value is valid given the datatype of the column.Finally, a new test method was added to check the validation function for all of the Felis datatypes, both when valid and invalid data is provided.