DM-43597: Remove outdated modules and their tests #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyMcCormick
force-pushed
the
tickets/DM-43597
branch
6 times, most recently
from
b7fb8db
to
b7a233b
Compare
|
@andy-slac These changes have been verified on CI in this build. |
Remove modules that have been fully deprecated, primarily by the switch to a Pydantic data model rather than using the raw YAML interface. These modules included: - check: This module has been completely replaced by Pydantic validation. - simple: This is the old data model that was replaced by a Pydantic implementation. - visitor: This is an implementation of a typed visitor pattern, which is not needed anymore. The corresponding test cases for these modules were removed as well. The `basic-check` command was removed from the `cli` module and the corresponding test was removed from `test_cli` as well.
JeremyMcCormick
force-pushed
the
tickets/DM-43597
branch
from
b7a233b
to
11c9a5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove modules that have been fully deprecated, primarily by the switch to a Pydantic data model rather than using the raw YAML interface.
These modules included:
check: This module has been completely replaced by Pydantic validation.simple: This is the old data model that was replaced by a Pydantic implementation.visitor: This is an implementation of a typed visitor pattern, which is not needed anymore.The corresponding test cases for these modules were removed as well.
The
basic-checkcommand was removed from theclimodule and the corresponding test was removed fromtest_clias well.dax_apdbchanges are merged to use the Pydantic data model instead ofsimple