DM-22470: Remove all uses of past and future from fgcm #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Jan 10, 2020
| @@ -1,5 +1,6 @@ | |||
| from __future__ import division, absolute_import, print_function | |||
| from past.builtins import xrange | |||
|
|
|||
| from builtins import range | |||
There was a problem hiding this comment.
You can remove this since it's not needed in python3.
|
|
||
| from builtins import range |
| @@ -1,6 +1,6 @@ | |||
| from __future__ import division, absolute_import, print_function | |||
There was a problem hiding this comment.
Please remove all the __future__ imports as well. Not needed.
| @@ -1,5 +1,6 @@ | |||
| from __future__ import division, absolute_import, print_function | |||
| from past.builtins import xrange | |||
|
|
|||
| from builtins import range | |||
| @@ -1,5 +1,5 @@ | |||
| from __future__ import division, absolute_import, print_function | |||
| from past.builtins import xrange | |||
| from builtins import range | |||
There was a problem hiding this comment.
Remove. I won't comment further on unnecessary use of from builtins import
| ('BANDS','a2',len(self.bands)), | ||
| ('FITBANDS','a2',len(self.fitBands)), | ||
| ('NOTFITBANDS','a2',len(self.notFitBands)), | ||
| ('LUTFILTERNAMES', 'a%d' % (maxFilterLen), len(self.lutFilterNames)), |
There was a problem hiding this comment.
Up to you but I think an f-string would look cleaner here.
| @@ -191,8 +194,8 @@ def computeZeropoints(self): | |||
| ('FGCM_APERCORR','f8'), | |||
| ('FGCM_CTRANS', 'f4'), | |||
| ('EXPTIME','f4'), | |||
| ('FILTERNAME','a2'), | |||
| ('BAND','a2'), | |||
| ('FILTERNAME', 'a%d' % (maxFilterLen)), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all uses of past and future, and update to v2.4.1.