DM-24738: Add background offset tracking to fgcmcal #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add delta-aperture background epsilon offset computations.
Update delta_aper epsilon to compute global backgrounds in better location.
Fix multprocessing on macos in new delta aper code.
Add default telescope rotation and fix index bug for delta-aper computation.
| self.fgcmLog.info("Cannot compute background x/y correlations without x/y information") | ||
| return | ||
|
|
||
| from .fgcmUtilities import plotCCDMapBinned2d |
There was a problem hiding this comment.
Is there a reason why the import is happening here, and not at the top of the file?
Fix delta aper units and other delta aper plotting bugs.
| @@ -63,7 +63,7 @@ def __init__(self, fgcmConfig, fgcmPars, fgcmStars): | |||
| self.fgcmLog.warn('No aperture radii set. Epsilon is unnormalized.') | |||
| self.epsilonNormalized = False | |||
|
|
|||
| self.njyZp = 48.6 - 9*2.5 | |||
| self.njyZp = 8.9 + 9*2.5 | |||
There was a problem hiding this comment.
I know I'm not technically required to review this PR, but woah, that's a huge drop. What happened here?
There was a problem hiding this comment.
I got my units confused completely on cgs vs janskys.
erykoff
added a commit
that referenced
this pull request
Feb 16, 2022
Add option to force htm matching when making stars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to delta-aperture-magnitude to track background offsets. Also some deprecation warnings have been fixed.