DM-31880: Update to version 3.9.0 with new reference star plots and cuts. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reference star color term residual plots.
Add reference residual color plots, reference color cuts, and per-exposure offset option.
laurenam
reviewed
May 23, 2022
fgcm/fgcmGray.py
Outdated
| @@ -1227,6 +1229,125 @@ def computeCCDAndExpDeltaMagBkg(self): | |||
| self.fgcmLog.info('Computed ccdDeltaBkg and expDeltaBkg in %.2f seconds.' % | |||
| (time.time() - startTime)) | |||
|
|
|||
| def computeExposureReferenceOffsets(self): | |||
| """Compute exposure reference offsets.""" | |||
There was a problem hiding this comment.
Future you might appreciate a more detailed description here...
fgcm/fgcmParameters.py
Outdated
| try: | ||
| self.compExpRefOffset = np.atleast_1d(inParams['COMPEXPREFOFFSET'][0]) | ||
| except: | ||
| # FIXME |
fgcm/fgcmStars.py
Outdated
| @@ -1532,6 +1548,7 @@ def performColorCuts(self): | |||
|
|
|||
| self.fgcmLog.info('Flag %d stars of %d with BAD_COLOR' % (bad.size,self.nStars)) | |||
|
|
|||
| # This config says "apply standard color cuts to reference stars" | |||
There was a problem hiding this comment.
Don't know what "standard" means here...
fgcm/fgcmChisq.py
Outdated
| @@ -620,6 +621,12 @@ def _magWorker(self, goodStarsAndObs): | |||
| # Regular non-sub-ccd | |||
| obsMagGO[ok] += ccdGray[obsExpIndexGO[ok], obsCCDIndexGO[ok]] | |||
|
|
|||
| if self.useExposureReferenceOffset: | |||
| # Apply the reference offsets as well. | |||
| # (There will probably be a sign error) | |||
Fix colorterm labels and other improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.