DM-43033: Update to fgcm 3.10.5 with reserved refstar updates. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can kick in for the first iteration, or for very limited coverage.
Fix some small issues when using/reserving reference stars.
Additional fixes for reference star reserving that were not properly handled with last PR
cmsaunders
approved these changes
Mar 6, 2024
| @@ -576,6 +576,10 @@ def loadStars(self, fgcmPars, | |||
| if test.size > 0: | |||
| self.fgcmLog.info('Flagging %d stars as reference star outliers from previous cycles.' % | |||
| (test.size)) | |||
| test, = np.where((flagFlag[a] & objFlagDict['REFSTAR_RESERVED']) > 0) | |||
| if test.size > 0: | |||
| self.fgcmLog.info('Flagging %d stars as reference star reserved from previous cycles.' % | |||
There was a problem hiding this comment.
This sentence isn't very clear. Something like 'Flagging %d stars as reference stars that were reserved from previous cycles.' (if I am correctly interpreting the original sentence) would be better.
There was a problem hiding this comment.
Changing it at this point will have to wait for the next version of fgcm, unless I go through a whole rigmarole. But thank you for pointing this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.