DM-43561: Update to fgcm 3.10.6 with distutils removal and plotting bug fixes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove distutils and fix image bugs
erykoff
changed the title
laurenam
approved these changes
Apr 10, 2024
fgcm/fgcmZeropoints.py
Outdated
| text = r'(%s)\n' % (filterName) | ||
| text += r'%s\n' % (plotType) | ||
| text += r"Blue: %s\n" % (self.blueString) | ||
| text += r"Red: %s\n" % (self.redString) |
There was a problem hiding this comment.
Usual mix-n-match of single vs double quotes (and below).
| @@ -450,7 +450,7 @@ def computeEpsilonPerCcd(self): | |||
| # ignore bands that have a range > 10 | |||
| deltaRange = scaleRange[:, 1] - scaleRange[:, 0] | |||
| filtersToMatchRange, = np.where(deltaRange < 20.0) | |||
| if filtersToMatchRange.size == 0: | |||
| if filtersToMatchRange.size > 0: | |||
There was a problem hiding this comment.
Squash this into d8c6a71 (or is it too late?)
| text += r"Red: %s\n" % (self.redString) | ||
| text = "(%s)\n" % (filterName) | ||
| text += "Blue: %s\n" % (self.blueString) | ||
| text += "Red: %s\n" % (self.redString) |
|
Since these are all unchecked formatting bits in upstream code that has already been merged to fgcm master, I think the ship has sailed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.