DM-16702: Upgrade fgcm to v2.1.2 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete overhaul so that this is now a computed parameter using repeated observations that are taken over a long enough baseline. The slope can also be computed per-band if desired. In addition, if sufficient refstars are available these will be plotted as a comparison to the instrumental parameters.
Also remove lots of temporary code.
Merge chromaticmirror branch
erykoff
added a commit
that referenced
this pull request
Aug 5, 2020
Add delta-bkg tracking, and improved SED handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers a major upgrade of the fgcm third-party package to v2.1.2, which includes numerous bug fixes and improvements to instrumental tracking, more robust fitting, and more. This is necessary to get good performance on HSC data.