DM-20163: Use PixelAreaBoundedField in fgcmcal calibration outputs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input magnitudes are now sanitized and flagged if they are bad, so that nans don't spoil everything. The input airmass of all observations is checked to confirm that they are within range of the LUT. Otherwise, the LUT code will not work properly. When "fgcmcal" (lsst) output is selected all zeropoints are possibly variable and flux-based, allowing better composition of constituent parts.
Update to 2.4.0
jmeyers314
reviewed
Jan 9, 2020
| @@ -116,6 +116,8 @@ def __init__(self,fgcmConfig): | |||
|
|
|||
| self.seeingSubExposure = fgcmConfig.seeingSubExposure | |||
|
|
|||
| self.secZenithRange = 1. / np.cos(np.radians(fgcmConfig.zenithRange)) | |||
There was a problem hiding this comment.
Feel free to ignore, but I've always preferred np.deg2rad() over np.radians since then in the input units are clear.
There was a problem hiding this comment.
I'll make this change in the next version of fgcm. I don't know why I'm using radians here, since I do usually use deg2rad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to
fgcmto support decomposition of wcs jacobian and superstar/gray components forfgcmcal.