Remove lookupStaticCalibrations and all usage of it.

Following DM-38498 static calibrations are now found correctly without
any customization by the task.

python/lsst/fgcmcal/fgcmBuildFromIsolatedStars.py

@@ -45,7 +45,6 @@
 
 from .fgcmBuildStarsBase import FgcmBuildStarsConfigBase, FgcmBuildStarsBaseTask
 from .utilities import computeApproxPixelAreaFields, computeApertureRadiusFromName
-from .utilities import lookupStaticCalibrations
 
 __all__ = ["FgcmBuildFromIsolatedStarsConfig", "FgcmBuildFromIsolatedStarsTask"]
 
@@ -58,7 +57,6 @@ class FgcmBuildFromIsolatedStarsConnections(pipeBase.PipelineTaskConnections,
         name="camera",
         storageClass="Camera",
         dimensions=("instrument",),
-        lookupFunction=lookupStaticCalibrations,
         isCalibration=True,
     )
     fgcm_lookup_table = connectionTypes.PrerequisiteInput(

python/lsst/fgcmcal/fgcmBuildStarsTable.py

@@ -43,7 +43,6 @@
 
 from .fgcmBuildStarsBase import FgcmBuildStarsConfigBase, FgcmBuildStarsBaseTask
 from .utilities import computeApproxPixelAreaFields, computeApertureRadiusFromName
-from .utilities import lookupStaticCalibrations
 
 __all__ = ['FgcmBuildStarsTableConfig', 'FgcmBuildStarsTableTask']
 
@@ -56,7 +55,6 @@ class FgcmBuildStarsTableConnections(pipeBase.PipelineTaskConnections,
         name="camera",
         storageClass="Camera",
         dimensions=("instrument",),
-        lookupFunction=lookupStaticCalibrations,
         isCalibration=True,
     )
 

python/lsst/fgcmcal/fgcmCalibrateTractTable.py

@@ -32,7 +32,6 @@
 from .fgcmBuildStarsTable import FgcmBuildStarsTableTask
 from .fgcmCalibrateTractBase import (FgcmCalibrateTractConfigBase,
                                      FgcmCalibrateTractBaseTask)
-from .utilities import lookupStaticCalibrations
 
 __all__ = ['FgcmCalibrateTractTableConfig', 'FgcmCalibrateTractTableTask']
 
@@ -45,7 +44,6 @@ class FgcmCalibrateTractTableConnections(pipeBase.PipelineTaskConnections,
         name="camera",
         storageClass="Camera",
         dimensions=("instrument",),
-        lookupFunction=lookupStaticCalibrations,
         isCalibration=True,
     )
 

python/lsst/fgcmcal/fgcmFitCycle.py

@@ -47,7 +47,6 @@
 from .utilities import makeZptSchema, makeZptCat
 from .utilities import makeAtmSchema, makeAtmCat, makeStdSchema, makeStdCat
 from .sedterms import SedboundarytermDict, SedtermDict
-from .utilities import lookupStaticCalibrations
 from .focalPlaneProjector import FocalPlaneProjector
 
 import fgcm
@@ -66,7 +65,6 @@ class FgcmFitCycleConnections(pipeBase.PipelineTaskConnections,
         name="camera",
         storageClass="Camera",
         dimensions=("instrument",),
-        lookupFunction=lookupStaticCalibrations,
         isCalibration=True,
     )
 

python/lsst/fgcmcal/fgcmMakeLut.py

@@ -40,7 +40,6 @@
 import lsst.afw.table as afwTable
 import lsst.afw.cameraGeom as afwCameraGeom
 from lsst.afw.image import TransmissionCurve
-from .utilities import lookupStaticCalibrations
 
 import fgcm
 
@@ -55,7 +54,6 @@ class FgcmMakeLutConnections(pipeBase.PipelineTaskConnections,
         name="camera",
         storageClass="Camera",
         dimensions=("instrument",),
-        lookupFunction=lookupStaticCalibrations,
         isCalibration=True,
     )
 
@@ -64,7 +62,6 @@ class FgcmMakeLutConnections(pipeBase.PipelineTaskConnections,
         name="transmission_optics",
         storageClass="TransmissionCurve",
         dimensions=("instrument",),
-        lookupFunction=lookupStaticCalibrations,
         isCalibration=True,
         deferLoad=True,
     )
@@ -74,7 +71,6 @@ class FgcmMakeLutConnections(pipeBase.PipelineTaskConnections,
         name="transmission_sensor",
         storageClass="TransmissionCurve",
         dimensions=("instrument", "detector",),
-        lookupFunction=lookupStaticCalibrations,
         isCalibration=True,
         deferLoad=True,
         multiple=True,
@@ -85,7 +81,6 @@ class FgcmMakeLutConnections(pipeBase.PipelineTaskConnections,
         name="transmission_filter",
         storageClass="TransmissionCurve",
         dimensions=("band", "instrument", "physical_filter",),
-        lookupFunction=lookupStaticCalibrations,
         isCalibration=True,
         deferLoad=True,
         multiple=True,

python/lsst/fgcmcal/fgcmOutputProducts.py

@@ -51,7 +51,6 @@
 import lsst.afw.table as afwTable
 
 from .utilities import computeApproxPixelAreaFields
-from .utilities import lookupStaticCalibrations
 from .utilities import FGCM_ILLEGAL_VALUE
 
 import fgcm
@@ -67,7 +66,6 @@ class FgcmOutputProductsConnections(pipeBase.PipelineTaskConnections,
         name="camera",
         storageClass="Camera",
         dimensions=("instrument",),
-        lookupFunction=lookupStaticCalibrations,
         isCalibration=True,
     )
 

python/lsst/fgcmcal/utilities.py

@@ -34,7 +34,6 @@
 import lsst.afw.math as afwMath
 import lsst.geom as geom
 from lsst.obs.base import createInitialSkyWcs
-from lsst.pipe.base import Instrument
 
 import fgcm
 
@@ -852,12 +851,3 @@ def extractReferenceMags(refStars, bands, filterMap):
         raise RuntimeError("FGCM reference stars missing FILTERNAMES metadata.")
 
     return refMag, refMagErr
-
-
-def lookupStaticCalibrations(datasetType, registry, quantumDataId, collections):
-    instrument = Instrument.fromName(quantumDataId["instrument"], registry)
-    unboundedCollection = instrument.makeUnboundedCalibrationRunName()
-
-    return registry.queryDatasets(datasetType,
-                                  dataId=quantumDataId,
-                                  collections=[unboundedCollection])